887: Git patch (aqcuired through git show > patch.diff) locks a thread and takes 100% cpu serverside

joche******@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Feb. 16, 2009 
What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. create a patch with git show 
2. try create a new review (and upload patch)
3. page keeps on loading, never stopping

What is the expected output? What do you see instead?
I'd love to have the review created and the diff visible
No review is created, and if one is created the patch is never there

What operating system are you using? What browser?
Mac OSX (firefox & safari), linux (Firefox)

Please provide any additional information below.
Server is Gentoo, with apache2 and reviewboard
(/ReviewBoard-1.0alpha3-py2.5.egg, /ReviewBoard-1.0alpha2-py2.5.egg) both
versions have the same issue.

THis is a blocker for us, we cannot use reviewboard at this time.
chipx86
#1 chipx86 
Looks like I missed a patch that would have fixed this. Sorry about that. If you'll
grab tonight's nightly (generated in about 20 minutes), this should be fixed.

It will be available at
http://downloads.review-board.org/nightlies/ReviewBoard-1.0beta1.dev_20090216-py2.5.egg

Fixed in r1790.
  • +Fixed
  • -Priority-Medium
    +Priority-Critical
    +Component-SCMTools
  • +chipx86
#2 joche******@gmai***** (Google Code) (Is this you? Claim this profile.) 
thanks! It works