734: Site Settings change requires Apache restart

matthew*******@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
April 4, 2009
858, 966 
What's the URL of the page containing the problem?
http://review.morristechnology.com/admin/settings/email/
http://review.morristechnology.com/admin/db/siteconfig/siteconfiguration/1/

What steps will reproduce the problem?
1. Change a setting on the first link and Save.
2. Notice the Email settings do not APPEAR to have been saved, but...
3. Visiting the second URL and viewing the config value reveals it has.
4. Restarting Apache syncs both the email settings form and the config form
value.

What is the expected output? What do you see instead?
Expected the Email settings to update immediately after being changed.

What operating system are you using? What browser?
Windows XP Professional, Firefox 3.0.3

Please provide any additional information below.
This may not be a bug per se, in fact it may be the intended functionality.
 I'm filing this as a precautionary measure.

Thanks for your time, and great work!
Matt
chipx86
#1 chipx86 
How recently have you updated Djblets and Review Board? We put out a fix for this a
few days ago.
#2 instan*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
I can confirm this bug. Change of settings don't appear to do anything. If I access
same setting page again I get random results - either old one before change or new
one after change (sometimes even template error page). After restarting apache
everything is back to normal and changed settings are updated.

My reviewboard version:
Fetching external item into 'djblets'
External at revision 11906.

Fetching external item into 'django_evolution'
External at revision 164.

Fetching external item into 'htdocs/media/djblets'
External at revision 11906.

At revision 1571.
chipx86
#3 chipx86 
I had thought we had fixed this.. Guess not.
  • +Confirmed
  • -Priority-Medium
    +Priority-Critical
    +Milestone-Release1.0
    +Component-Settings
david
#4 david 
This should be fixed now.
  • -Confirmed
    +Fixed
chipx86
#5 chipx86 
Sadly, no. There's still some issues that happen on occasion. I haven't figured it
out yet. I saw this just the other day.
  • -Fixed
    +Confirmed
  • +chipx86
chipx86
#6 chipx86
chipx86
#7 chipx86
chipx86
#8 chipx86 
So, I've been unable to reproduce this lately, and am wondering if it was fixed
through something else. If anyone else can reproduce this, please let me know your
exact configuration (web server, caching server, database type, mod_python/fastcgi, etc.)
chipx86
#9 chipx86 
I believe I found potential causes for this. There were ways of getting to stale
cached versions of a siteconfig, and we were definitely using these in places in our
code.

This should now be fixed in Djblets r12012.

Please comment if you still encounter this after tomorrow's (April 4, 2009) nightly.
  • -Confirmed
    +Fixed
#10 barry******@gmai***** (Google Code) (Is this you? Claim this profile.) 
I'm seeing this behavior on 1.5Beta 1. Restarting apache gets the settings to take
but without that many settings are not being saved when changed in the admin UI.
chipx86
#11 chipx86 
Yeah, it's definitely a bug in 1.5 beta 1, but I'd like to see if people still hit it
with the latest nightlies of both Review Board and Djblets.