3931: UnicodeDecodeError: 'ascii' codec can't decode byte 0xe9 in position 535: ordinal not in range(128)

di***@microd******* (Google Code) (Is this you? Claim this profile.)
david
david
July 28, 2015
What version are you running?

2.0.18
What's the URL of the page containing the problem?
r/3355/diff/1#index_header

What steps will reproduce the problem?
1. Try to open uploaded cvs diff in diff viewer


What is the expected output? What do you see instead?
View diff. Error pasted in the addition information

What operating system are you using? What browser?
Windows 7 and Chrome

Please provide any additional information below.
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.18-py2.7.egg/reviewboard/diffviewer/views.py", line 265, in get
    response = renderer.render_to_response(request)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.18-py2.7.egg/reviewboard/diffviewer/renderers.py", line 56, in render_to_response
    return HttpResponse(self.render_to_string(request))
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.18-py2.7.egg/reviewboard/diffviewer/renderers.py", line 74, in render_to_string
    large_data=True)
  File "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.21-py2.7.egg/djblets/cache/backend.py", line 111, in cache_memoize
    data = lookup_callable()
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.18-py2.7.egg/reviewboard/diffviewer/renderers.py", line 73, in <lambda>
    lambda: self.render_to_string_uncached(request),
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.18-py2.7.egg/reviewboard/diffviewer/renderers.py", line 87, in render_to_string_uncached
    request=request)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.18-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 422, in populate_diff_chunks
    chunks = generator.get_chunks()
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.18-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 156, in get_chunks
    large_data=True)
  File "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.21-py2.7.egg/djblets/cache/backend.py", line 111, in cache_memoize
    data = lookup_callable()
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.18-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 155, in <lambda>
    lambda: list(self._get_chunks_uncached()),
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.18-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 163, in _get_chunks_uncached
    new = get_patched_file(old, self.filediff, self.request)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.18-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 231, in get_patched_file
    filediff.source_revision)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.18-py2.7.egg/reviewboard/scmtools/cvs.py", line 98, in normalize_patch
    return self.client.collapse_keywords(patch)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.18-py2.7.egg/reviewboard/scmtools/cvs.py", line 411, in collapse_keywords
    return regex.sub(r'$\1$', data)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe9 in position 535: ordinal not in range(128)
david
#1 david
  • +PendingReview
  • +Component-SCMTools
  • +david
david
#2 david
Fixed in release-2.0.x (3977b23). This will ship in 2.0.19. Thanks!
  • -PendingReview
    +Fixed