3865: rbt post fails when random repository is misconfigured in reviewboard

jonatha*******@gmai***** (Google Code) (Is this you? Claim this profile.)
david
david
May 18, 2015
What version are you running?
rbtools 0.7.2
reviewboard 2.0.6


What's the URL of the page containing the problem?
https://<reviewboard>/api/repositories/2/info/


What steps will reproduce the problem?
1. rbt post

What is the expected output? What do you see instead?
Expect rbt to successfully connect and post review, since web interface works fine.

Instead, see:
>>> repository info: Path: https://<svn-domain>/svn/<my_repo>, Base path: /, Supports changesets: False
>>> Making HTTP GET request to https://<reviewboard>/api/
>>> Making HTTP GET request to https://<reviewboard>/api/repositories/
>>> Making HTTP GET request to https://<reviewboard>/api/repositories/1/info/
>>> Making HTTP GET request to https://<reviewboard>/api/repositories/2/info/
>>> Got API Error 210 (HTTP code 500): There was an error fetching extended information for this repository.
>>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error fetching extended information for this repository.', u'code': 210}}
Traceback (most recent call last):
  File "/usr/bin/rbt", line 9, in <module>
    load_entry_point('RBTools==0.7.2', 'console_scripts', 'rbt')()
  File "/usr/lib/python2.7/site-packages/rbtools/commands/main.py", line 133, in main
    command.run_from_argv([RB_MAIN, command_name] + args)
  File "/usr/lib/python2.7/site-packages/rbtools/commands/__init__.py", line 555, in run_from_argv
    exit_code = self.main(*args) or 0
  File "/usr/lib/python2.7/site-packages/rbtools/commands/post.py", line 603, in main
    repository_info = repository_info.find_server_repository_info(api_root)
  File "/usr/lib/python2.7/site-packages/rbtools/clients/svn.py", line 762, in find_server_repository_info
    info = repository.get_info()
  File "/usr/lib/python2.7/site-packages/rbtools/api/resource.py", line 146, in <lambda>
    self._get_url(url, **kwargs)))
  File "/usr/lib/python2.7/site-packages/rbtools/api/decorators.py", line 27, in request_method
    *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/rbtools/api/transport/sync.py", line 65, in execute_request_method
    return self._execute_request(request)
  File "/usr/lib/python2.7/site-packages/rbtools/api/transport/sync.py", line 74, in _execute_request
    rsp = self.server.make_request(request)
  File "/usr/lib/python2.7/site-packages/rbtools/api/request.py", line 536, in make_request
    self.process_error(e.code, e.read())
  File "/usr/lib/python2.7/site-packages/rbtools/api/request.py", line 509, in process_error
    rsp['err']['msg'])
rbtools.api.errors.APIError: There was an error fetching extended information for this repository. (HTTP 500, API Error 210)


What operating system are you using? What browser?
Linux 4.0.1-1-ARCH #1 SMP PREEMPT x86_64 GNU/Linux
Chromium Version 42.0.2311.135 (64-bit)

Please provide any additional information below.
Repository #2 is an old repository that (I guess) is no longer connected to an SVN server, or it is misconfigured in some other way. The repository I'm interested in (#30), is working fine. I would expect rbt post to keep scanning repositories and only fail once it knows there is no match available.
david
#1 david
  • +PendingReview
  • +Component-RBTools
  • +david
david
#2 david
Fixed in release-0.7.x (e38048f). This will ship in 0.7.3. Thanks!
  • -PendingReview
    +Fixed