3787: "TypeError: must be char, not unicode" when installing reviewboard on windows.

der.*****@gmai***** (Google Code) (Is this you? Claim this profile.)
March 4, 2015 
What version are you running?
2.1.13

What's the URL of the page containing the problem?
Reviewboard/cmdline/rbsite.py

What steps will reproduce the problem?
1. easy_install reviewboard
2. rb-site install D:\reviewboard\www
3. Domain: "Domain"
4. Path: "/reviewboard/"
5. DB Name: "reviewboard"
6. DB Server: "domain"
7. DB User: "user"

What is the expected output? What do you see instead?
Prompt for DB user password

What operating system are you using? What browser?
Windows7 eng CMD

Please provide any additional information below.
Traceback (most recent call last):
  File "C:\Python27\Scripts\rb-site-script.py", line 9, in <module>
    load_entry_point('ReviewBoard==2.0.13', 'console_scripts', 'rb-site')()
  File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1883, in main
    command.run()
  File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1225, in run
    self.ask_database_login()
  File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 1438, in ask_database_login
    save_obj=site, save_var="db_pass")
  File "C:\Python27\lib\site-packages\reviewboard-2.0.13-py2.7.egg\reviewboard\cmdline\rbsite.py", line 942, in prompt_input
    temp_value = getpass.getpass(prompt)
  File "C:\Python27\lib\getpass.py", line 95, in win_getpass
    msvcrt.putch(c)
TypeError: must be char, not unicode

Can be fixed by replacing line 944 with:
temp_value = getpass.getpass(prompt = prompt.encode('ascii','ignore'))

Best regards, Stefan
#1 Chester.********@gmai***** (Google Code) (Is this you? Claim this profile.) 
1. I am confused with your "What is the expected output? What do you see instead?"
2. Please indicate that in which file the line 944 is.
3. Is each step a command?
#2 der.*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
review request: https://reviews.reviewboard.org/r/6983/

Hi Chester,

About 1.
Step 1 is downloading reviewboard
Step 2 is the installation of a reviewboard site.
Step 3 to 7 are filling the variables (in cmd) required to install.

2. The fix is in \reviewboard\cmdline\rbsite.py

3. No Step 3 to 7 reviewboard asks for values in cmd
#3 Chester.********@gmai***** (Google Code) (Is this you? Claim this profile.) 
Hi Stefan!

What is the expected output?
What do you see?
#4 der.*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I updated my review request.
Please have a look there. Then we not have to communicate on two channels.
david
#5 david 
Fixed in release-2.0.x (d5c710a). Thanks!
  • +Fixed