3501: djblets references cloudflare cdn

josh.******@gmai***** (Google Code) (Is this you? Claim this profile.)
david
david
March 13, 2015
I run reviewboard behind a firewall, and references to cloudflare cause a few parts of the site to fail.


What version are you running?
2.0.4 (djblets 0.8.7)

What's the URL of the page containing the problem?
admin/extensions/

What steps will reproduce the problem?
1. load the extensions page behind a firewall

What is the expected output? What do you see instead?
The list of extensions loads; instead i see an ajax spinner and javascript errors "Backbone is not defined" and "Djblets.ExtensionManager is not a constructor"

What operating system are you using? What browser?
RHEL 6/firefox 30

Please provide any additional information below.

the files djblets/util/templates/js/underscore|backbone.html are trying to load data from cloudflare.  I manually copied the js files to a static location on my webserver, edited those files to point to the new static files, and then regenerated static files.  After that, the extension page loads correctly.

https://github.com/djblets/djblets/blob/master/djblets/util/templates/js/underscore.html#L1
david
#1 david
Review Board is supposed to override this, but I guess it's broken for the extensions admin page.
  • +Component-Admin
    +EasyFix
    +Project-ReviewBoard
david
#2 david
  • +PendingReview
  • +david
david
#3 david
Fixed in release-2.0.x (cb12831). Thanks!
  • -PendingReview
    +Fixed