2195: Perforce support is broken with Python 2.4 in RC2

chipx86
chipx86
chipx86
July 30, 2011
What version are you running?
1.6 RC2


Please provide any additional information below.
A recent change added a finally: block to the exceptions in Perforce. This isn't supported with Python 2.4, and will need to be updated until we break away from 2.4.
chipx86
#1 chipx86
  • +PendingReview
  • +chipx86
#2 Greg.*****@gmai***** (Google Code) (Is this you? Claim this profile.)
I think this issue may be what is causing the following error when I try to bring up the "add repository" page.

=========
[[ stack trace deleted for sake of brevity ]]

  File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6rc2-py2.4.egg/reviewboard/scmtools/perforce.py", line 155

    finally:

          ^

SyntaxError: invalid syntax


<ModPythonRequest
path:/admin/db/scmtools/repository/add/,

[[ remainder of request data deleted ]]
chipx86
#3 chipx86
Tonight's nightly build will have the fix.
chipx86
#4 chipx86
Fixed on master. It missed tonight's build but will be in tomorrow's.
  • -PendingReview
    +Fixed