1661: Allow multiple mailing lists for a review group.
- Fixed
- Review Board
| tli****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
 |
|
| Jan. 23, 2014 |
What version are you running?
1.0.7
What steps will reproduce the problem?
1. Try to set up a comma separated list of mailing lists for a review group
What is the expected output? What do you see instead?
The form validation says the comma separated list is not a correct email
address.
I worked around that by just setting the field in the DB manually, since I
noticed reviews/emails.py has some logic for looking for "," in the field.
But there's a slight bug there:
else:
# The mailing list field has multiple e-mail addresses in it.
# We don't know which one should have the group's display name
# attached to it, so just return their custom list as-is.
return g.mailing_list
should be
return g.mailing_list.split(",")
After this change, it works as expected.
This is currently working as designed, but it might be nice to allow lists.
-
- Type-Defect + Type-Enhancement -
+ Allow multiple mailing lists for a review group.
If designed this way, why does that else clause exist? seems like it was half-implemented.
-
+ Component-Reviews
-
+ Fixed
Not sure if this should be closed yet - the form validator also needs to allow comma-separated lists. I hacked the comma-separated list directly into the DB, but you can't do it through the standard interface yet.
-
- Component-Reviews + Component-Admin
-
- New + PendingReview -
+ david
OK, completely fixed in master (4d097c1). This will ship in 2.0 beta 3.
-
- PendingReview + Fixed