1500: "xx lines hidden [Expand]" link stopped working
- Fixed
- Review Board
| jahu****@nvidi***** (Google Code) (Is this you? Claim this profile.) | |
| Feb. 22, 2010 | |
| 1504, 1512, 1525, 1558, 1584, 1619, 1654 |
What version are you running? 1.5 beta 2, dev builds 2/16 (issue also seen in 2/10) What's the URL of the page containing the problem? Issue can be seen on: http://reviews.reviewboard.org/r/1410/diff/#index_header What steps will reproduce the problem? > On above link, click on "124 lines hidden [Expand]" What is the expected output? What do you see instead? > Expect to see lines of code expanded. E.g. on above link, expect last hidden 124 lines to be expanded Instead, the "Loading" icon goes away, and the screen remains as is. What operating system are you using? What browser? Verified on XP and Windows 7. Verified on IE 7, IE 8, and Firefox.
Are there any javascript errors or errors in the server log?
-
+ NeedInfo -
+ Component-DiffViewer
The problem appears to be that the commit http://github.com/chipx86/reviewboard/commit/7ef6e623398bb198c7b2f6cf3dc1de1673989ed6 changed "tbody.collapsed" to "tbody.diff-header" in diff_file_fragment.html, but the JS code in diffviewer.js is still looking for "tbody.collapsed": http://github.com/chipx86/reviewboard/blob/master/reviewboard/htdocs/media/rb/js/diffv iewer.js#L971
-
- NeedInfo + Fixed
