939: post-review broken on windows when using options --revision-range and --repository-url

jeremy*******@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
April 23, 2009
On windows only, when using this command line:

python post-review --username username --password password
--target-groups=groupname --publish --submit-as=username
--branch="/a/path/name" --revision-range=95695:96202 --summary="Changes to
/a/path/name in 95695:96202 by username" --description-file=svnlogtemp.txt
--repository-url="http://svn.example.com/svnroot/a/path/name"

gives an error when generating the svn diff.  The reason is because
post-review is putting a backslash into the url passed to svn.

I have attached a patch that fixes the problem.
--- c:\Documents and Settings\jbettis\Desktop\post-review.txt	Wed Mar 04 16:27:31 2009
+++ c:\bin\post-review	Wed Mar 04 16:25:59 2009
@@ -1255,7 +1255,7 @@
                     # add initial slash.
                     if options.repository_url:
                         path = urllib.unquote(
-                            os.path.join(repository_info.base_path, file))
+                            repository_info.base_path + "/" + file)
                     else:
                         info = self.svn_info(file)
                         url  = info["URL"]
david
#1 david
Please post this patch on http://reviews.review-board.org/

Thanks!
chipx86
#2 chipx86
Fixed in r1929.
  • +Confirmed
  • +Milestone-Release1.0
    +Component-RBTools
  • +chipx86
chipx86
#3 chipx86
  • -Confirmed
    +Fixed