828: Anchors to lines in diff viewer don't work

mkoe****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Feb. 16, 2009
What's the URL of the page containing the problem?
Any URL of the format
http://host/reviewboard/r/1148/diff/1/?file=26188#file26188line161

What steps will reproduce the problem?
1. go to a review and view the comments to a certain line of code in the diff
2. Click on the line of code which is a link with a url similar as
described above
3. The browser shows you the diff but does not scroll down to the
previously clicked line of code.

What is the expected output? What do you see instead?
I would expect that the browser scrolls down to the line of code I just
clicked on.

What operating system are you using? What browser?
firefox 2 & 3, linux and windows

Please provide any additional information below.
Not sure whether that is related...(probably not)
Under windows only and firefox 2 I get the following js error when I click
on the link to the line of code a comment was left for:

Error: [Exception... "Component is not available"  nsresult: "0x80040111
(NS_ERROR_NOT_AVAILABLE)"  location: "JS frame ::
file:///C:/PROGRA~1/MOZILL~1/components/nsSessionStore.js :: sss_saveState
:: line 1772"  data: no]
Source File: file:///C:/PROGRA~1/MOZILL~1/components/nsSessionStore.js
Line: 1772

the code it refers to is:

  /**

   * save state to disk

   * @param aUpdateAll

   *        Bool update all windows 

   */

  saveState: function sss_saveState(aUpdateAll) {

    // if crash recovery is disabled, only save session resuming information

    if (!this._resume_from_crash && this._loadState == STATE_RUNNING)

      return;

    

    this._dirty = aUpdateAll;

    var oState = this._getCurrentState();

1772:    oState.session = { state: ((this._loadState == STATE_RUNNING) ?
STATE_RUNNING_STR : STATE_STOPPED_STR) };

    this._writeFile(this._sessionFile, oState.toSource());

    this._lastSaveTime = Date.now();

  },
chipx86
#1 chipx86
  • +Confirmed
  • +Milestone-Release1.0
    +Component-DiffViewer
chipx86
#2 chipx86
That error seems unrelated.

Found and fixed the problem. Should be fixed in r1702.
  • -Confirmed
    +Fixed
  • +chipx86
#3 mkoe****@gmai***** (Google Code) (Is this you? Claim this profile.)
the progressive load must have come in its way.

Initially, the anchor is not visited.
So you click on the link, the browser loads the diff but does not scroll down.
If you now click with the mouse into the URL field of your browser and hit enter (not
F5!), the browser will now scroll down to it.
chipx86
#4 chipx86
Ah, right, that definitely will cause issues. I'll look into possible fixes for this
for beta 1.
  • -Fixed
    +Confirmed
chipx86
#5 chipx86
Fixed in r1783.
  • -Confirmed
    +Fixed