827: Anonymous users can create comments in diff viewer

mkoe****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Jan. 23, 2009
Assuming, you have configured your reviewboard server so that anonymous
users can view reviews and diffs

What steps will reproduce the problem?
1. Go to your reviewboard server and logout should you still be logged in
2. As anonymous user, go to a review and view the diff
3. You now can leave comments to lines of the viewed diff

What is the expected output? What do you see instead?
Since I am logged in as anonymous, I should not be able to create comments.


What operating system are you using? What browser?
Firefox 2&3 on linux and windows.

Please provide any additional information below.
Once you have created comments as anonymous, you can click either on edit
review or publish which will give you the login screen. Once you are logged
in, you are actually still not logged in because if you now view a diff, it
still says "Log-In" in the top right corner instead of your name.
But I think this won't be an issue anymore once anonymous users can't
create comments in the first place.
chipx86
#1 chipx86
  • +Started
  • -Priority-Medium
    +Priority-Critical
    +Milestone-Release1.0
    +Component-DiffViewer
  • +chipx86
chipx86
#2 chipx86
Good news is, it just *looks* like the user can create comments. Nothing's actually
being saved in the database. We just need UI to prevent comment creation.
chipx86
#3 chipx86
Fixed in r1696.
  • -Started
    +Fixed