748: Commenter name is sometimes missing from the body of reviewboard emails

jameslin
chipx86
 chipx86
Aug. 22, 2009 
What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Arthur posts a review request.
2. Beatrix replies to Arthur's diff.
3. Cthulhu replies to Beatrix's comments.
4. Dave replies to Cthulhu's comments.

What is the expected output? What do you see instead?

In the final email, I see something of the form:

   > On <DATE>, Beatrix wrote:
   > > path-to-file, line 123
   > > <url-to-line>
   > >
   > >     You should do X. --Beatrix
   >
   >  wrote:
   >     I tried to do X, but it didn't work. --Cthulhu

   You should try doing Y instead. --Dave

Note that Cthulhu's name is missing.

I can supply an actual email if needed (I'd rather not post it publicly).
#1 jameslin 
I've also seen a case where:

1. Arthur posts a review request.
2. Beatrix replies.
3. Arthur replies to Beatrix's comments.

and then the email says:
On <DATE>, Arthur wrote:
> > Blah. --Beatrix

Blah. --Arthur

which makes it seem like Arthur is replying to himself.
david
#2 david
  • +Confirmed
chipx86
#3 chipx86
  • +Milestone-Release1.1
#4 jameslin 
Really?  1.1?  This is pretty visible...
chipx86
#5 chipx86
  • -Milestone-Release1.1
    +Milestone-Release1.0.x
chipx86
#6 chipx86
  • -Confirmed
    +Started
  • +chipx86
chipx86
#7 chipx86 
Fixed in r2101 (in branches/reviewboard/1.0.x) for v1.0.2.

This is also being fixed as part of a larger change in trunk, so I'm leaving this
open for now.
chipx86
#8 chipx86 
Fixed for 1.1 in r2110.
  • -Started
    +Fixed