696: Previous/next file shortcut keys are broken

jameslin
chipx86
chipx86
Feb. 16, 2009
What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. View a diff.
2. Press < or > a bunch of times.

What is the expected output? What do you see instead?
< and > should go to the previous/next file, but they're inconsistent. 
Sometimes they'll stop in the middle of the diff.  Sometimes they go in the
wrong direction.  Sometimes they seem to skip around randomly...


What operating system are you using? What browser?
Windows XP 64 sp2

Please provide any additional information below.
chipx86
#1 chipx86
This should be fixed in my UI rewrite.
  • +Confirmed
  • +Milestone-Release1.0
    +Component-DiffViewer
    +Keyboard
  • +chipx86
chipx86
#2 chipx86
  • -Confirmed
    +Started
chipx86
#3 chipx86
Fixed in r1644.
  • -Started
    +Fixed
#4 jameslin
I'm still seeing this on the internal VMware reviewboard server.
chipx86
#5 chipx86
Okay, it does seem to be broken in some cases.
  • -Fixed
    +Confirmed
chipx86
#6 chipx86
Definitely fixed now in r1782.
  • -Confirmed
    +Fixed