4911: ReviewBoard 4 for svn repositories can't Create from a local change

Rand01ph
chipx86
chipx86

What version are you running?

Both 4.0 beta 1 and 4.0 beta 2

What's the URL of the page containing the problem?

/r/new/

What steps will reproduce the problem?

  1. New Review Request
  2. Create from a local change click Select Button
  3. choose one diff create from svn diff

What is the expected output? What do you see instead?

I expected to choose basedir, but the /api/validation/diffs/ api return 400 Bad Request
the body is
{
"err": {
"code": 105,
"msg": "One or more fields had errors"
},
"fields": {
"basedir": [
"Given repository requires a base directory"
]
},
"stat": "fail"
}

What operating system are you using? What browser?

OS is macOS Big Sur 11.1
Browser is Chrome 88.0.4324.96

Please provide any additional information below.

chipx86
#1 chipx86

Fix up for review at https://reviews.reviewboard.org/r/11470/

This will be part of RC 1 this week.

  • -New
    +Fixed
  • +Release-4.0
  • +Component:Reviews
    +Priority:Critical
    +SCM:Subversion
  • +chipx86