4629: Unreachable transaction close code in reviewboard/admin/management/commands/loaddb.py
- Fixed
- Review Board
david | |
What version are you running?
release-4.0.x @ac9782805
The loaddb management command has a bug where the code to rollback the transaction occurs after a "raise", meaning it will never be reached. We need to reorder this so the raise happens after the transaction code.
See https://sonarcloud.io/project/issues?id=reviewboard&issues=AWDsgtA3ikuHJGLsZjiX&open=AWDsgtA3ikuHJGLsZjiX for the actual code in question.