4535: License issue with GPL

fgallaire
chipx86
chipx86

Review Board is under the MIT license, but use Mercurial and Bazaar which are under the "viral" GNU GPL license.

#1 fgallaire

Seems fixed for mercurial https://hellosplat.com/s/beanbag/tickets/3159/, but not for Bazaar.

chipx86
#2 chipx86

Mercurial was indeed fixed a while back. We use the command line tool now, though we do check for the existence of the mercurial module (we don't use it, just test if it exists), but yeah, that should be checking for the command instead.

Bazaar was a contribution from a long time ago. We'll need to do some work to get that off the module. We'll get that into the next release.

  • -New
    +Confirmed
  • +Release-2.0.x
    +Release-2.5.x
  • -Priority:Medium
    +Component:SCMTools
    +Priority:Critical
    +SCM:Bazaar
    +SCM:Mercurial
  • +chipx86
chipx86
#3 chipx86

Rewrite up for review at https://reviews.reviewboard.org/r/8835/

  • -Confirmed
    +PendingReview
chipx86
#4 chipx86

Fixed in 4832100bf4d2ea41c74b7e605d431b69862e71fb. Releases are going out.

  • -PendingReview
    +Fixed