4484: Commit_id no more shows if it is pending (perforce repository)

subodhk
chipx86
chipx86
4500

What version are you running?

2.5.7

What's the URL of the page containing the problem?

review/r/<reviewid>/

What steps will reproduce the problem?

  1. install reviewboard 2.5.7
  2. rbt post <CL_No>

What is the expected output? What do you see instead?

Review request when opened should show "Change: 549348 (pending)" as it is a pending CL
Review request when opened displays as "Change: 549348" which is not expected.

What operating system are you using? What browser?

CentOS 6

Please provide any additional information below.

Tested the scenario in 2.5.6.1 and the change is shown properly

Below is the culprit sql

2.5.3/2.5.6.1
INSERT INTO reviews_reviewrequest (description, description_rich_text, testing_done, testing_done_rich_text, bugs_closed, branch, commit_id, extra_data, rich_text, summary, submitter_id, time_added, last_updated, status, public, changenum, repository_id, email_message_id, time_emailed, diffset_history_id, last_review_timestamp, shipit_count, issue_open_count, issue_resolved_count, issue_dropped_count, local_site_id, local_id) VALUES ('RBT Test 3\n=bug9690333 fix-partial ', 0, '', 0, '9690333', 'tools', '549348', '{}', 0, 'RBT Test 3 =bug9690333 fix-partial ', 1244, '2016-11-10 07:29:06', '2016-11-10 07:29:06', 'P', 0, 549348, 1, NULL, NULL, 63093, NULL, 0, 0, 0, 0, NULL, NULL)

2.5.7
INSERT INTO reviews_reviewrequest (description, description_rich_text, testing_done, testing_done_rich_text, bugs_closed, branch, commit_id, extra_data, rich_text, summary, submitter_id, time_added, last_updated, status, public, changenum, repository_id, email_message_id, time_emailed, diffset_history_id, last_review_timestamp, shipit_count, issue_open_count, issue_resolved_count, issue_dropped_count, local_site_id, local_id) VALUES ('', 0, '', 0, '', '', NULL, '{}', 0, '', 1244, '2016-11-10 07:23:15', '2016-11-10 07:23:15', 'P', 0, NULL, 1, NULL, NULL, 69438, NULL, 0, 0, 0, 0, NULL, NULL)

#1 jamie
  • +Release-2.5.x
  • +Component:SCMTools
    +SCM:Perforce
chipx86
#3 chipx86

Posted for review at https://reviews.reviewboard.org/r/8609/

  • -New
    +PendingReview
  • +chipx86
chipx86
#4 chipx86
  • -PendingReview
    +Fixed