422: "Discard Review" and "Set Submitted" should send email

nzm****@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 27, 2013
637
What steps will reproduce the problem?
1. Create and publish a review.
2. Delete that review.

What is the expected output? What do you see instead?
I would expect an email sent to the reviewers to notify them that the
review request was deleted and who deleted it.
chipx86
#1 chipx86
  • -Type-Defect
    +Type-Enhancement
    +Component-Reviews
  • +"Discard Review" should send email
david
#3 david
  • -"Discard Review" should send email
    +"Discard Review" and "Set Submitted" should send email
david
#4 david
  • +Confirmed
#5 aksh*****@gmai***** (Google Code) (Is this you? Claim this profile.)
It would be also great if it logged this action (submitted or discarded) as a history via comment.
david
#6 david
Fixed in release-1.7.x (4666a7e). Thanks!
  • -Confirmed
    +Fixed
#7 jesse.p*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Is this action configurable?  Personally I find this "feature" to be a nuisance.  After someone approves my review with a "ship it" notification, why do we need to have yet one more email come into our boxes to say this was submitted or discarded?

I can see how if someone was using this for their defect tracking system then you might want this, but if you use JIRA or some other defect tracking system then that's the only source of email I want to get to say a defect has been resolved.
chipx86
#8 chipx86
It's a completely optional feature, off by default. You'd have to talk to your administrator about why it's turned on. Most places don't have this enabled.