4057: Publishing possible from the Web API when no reviewers or groups specified

smacleod
4593 
What version are you running?


2.5.2


What's the URL of the page containing the problem?


.../r/####

.../api/review-requests/####


What steps will reproduce the problem?


    

  1. Create a review request with no reviewers or groups assigned
    2. 

  2. Attempt to publish using the normal UI
    3. 

  3. Publish is prevented
    4. 

  4. Attempt to publish with PUT .../api/review-requests/####/draft/ public=1
    5. 

  5. Review request is published.
    6. 





What is the expected output? What do you see instead?


Publishing should be prevented from the API (or not prevented in the UI?) when there are no reviewers or review groups. Instead, API publishing is allowed.
brennie
#1 brennie
  • +EasyFix
#2 smacleod
  • -New
    +Confirmed
  • +Component:API
    +Component:Reviews
    +OpSys:All
#3 nfredette
  • +nfredette
brennie
#4 brennie
  • -nfredette
#5 m.m888 
on it
david
#6 david
#7 maram 
I'll work on this
david
#8 david 
Fixed in release-3.0.x (2857ab8). This will ship in 3.0.4.
  • -Confirmed
    +Fixed