4054: File attachments aren't deleted when removed from review requests

brennie
WeijieSun

What version are you running?

2.0+

What's the URL of the page containing the problem?

r/XXXX/file/YYYY/

What steps will reproduce the problem?

  1. Create a review request
  2. Upload a file attachment
  3. Delete the file attachment
  4. Publish the review request

What is the expected output? What do you see instead?

The file should be deleted and inaccessible and the FileAttachment instance should be deleted. However, the file is still available.

What operating system are you using? What browser?

Any.

Please provide any additional information below.

Deleting the FileAttachment instance should result in the file being deleted.

brennie
#1 brennie
  • +EasyFix
david
#2 david

Note that this should only be deleted if the file attachment was deleted before the draft is published. Removing a "public" file attachment should keep the data.

#3 WeijieSun
  • +WeijieSun
david
#4 david

Fixed in release-2.5.x (9d5f2e1). This will ship in 2.5.4.

  • -New
    +Fixed