3999: Incorrect payload sent to WebHook for 'Reply published' event

pawolf
david
david

What version are you running?

2.5 RC1

What's the URL of the page containing the problem?

N/A

What steps will reproduce the problem?

  1. Create a review request
  2. Create a review
  3. Reply to the review

What is the expected output? What do you see instead?

The payload data sent to the WebHook appears to be malformed. The links have the reply ID substituted for the review ID.

What operating system are you using? What browser?

Ubuntu 12.04.4 LTS, FireFox 41.0.2

Please provide any additional information below.

I've attached two files. 'API response.txt' is the response I get when I use the REST API to create a review reply. The data here is what I expect. 'WebHook payload.txt' is the data received by my WebHook that gets called as a result of the review reply being published. The data here is not what I expect.

{
	"reply": {
		"body_top": "My reply",
		"extra_data": {
		},
		"links": {
			"diff_comments": {
				"href": "http://reviewboard.acme.com/api/review-requests/183/reviews/250/replies/254/diff-comments/",
				"method": "GET"
			},
			"file_attachment_comments": {
				"href": "http://reviewboard.acme.com/api/review-requests/183/reviews/250/replies/254/file-attachment-comments/",
				"method": "GET"
			},
			"self": {
				"href": "http://reviewboard.acme.com/api/review-requests/183/reviews/250/replies/254/",
				"method": "GET"
			},
			"update": {
				"href": "http://reviewboard.acme.com/api/review-requests/183/reviews/250/replies/254/",
				"method": "PUT"
			},
			"screenshot_comments": {
				"href": "http://reviewboard.acme.com/api/review-requests/183/reviews/250/replies/254/screenshot-comments/",
				"method": "GET"
			},
			"user": {
				"href": "http://reviewboard.acme.com/api/users/pawolf/",
				"method": "GET",
				"title": "pawolf"
			},
			"delete": {
				"href": "http://review
{
	"reply": {
		"body_top": "My reply",
		"ship_it": false,
		"extra_data": {
		},
		"links": {
			"diff_comments": {
				"href": "http://reviewboard.acme.com/api/review-requests/183/reviews/254/diff-comments/",
				"method": "GET"
			},
			"file_attachment_comments": {
				"href": "http://reviewboard.acme.com/api/review-requests/183/reviews/254/file-attachment-comments/",
				"method": "GET"
			},
			"self": {
				"href": "http://reviewboard.acme.com/api/review-requests/183/reviews/254/",
				"method": "GET"
			},
			"update": {
				"href": "http://reviewboard.acme.com/api/review-requests/183/reviews/254/",
				"method": "PUT"
			},
			"screenshot_comments": {
				"href": "http://reviewboard.acme.com/api/review-requests/183/reviews/254/screenshot-comments/",
				"method": "GET"
			},
			"user": {
				"href": "http://reviewboard.acme.com/api/users/pawolf/",
				"method": "GET",
				"title": "pawolf"
			},
			"replies": {
				"href": "http://reviewboard.acme.com/api/review-requests/183/
chipx86
#1 chipx86
  • -New
    +Confirmed
  • +Release-2.5.x
  • +david
david
#2 david
  • -Confirmed
    +PendingReview
david
#3 david

Fixed in release-2.5.x (48389ed). This will ship in 2.5.1. Thanks!

  • -PendingReview
    +Fixed
pawolf
#4 pawolf

David, Thanks for the quick turn-around. I installed 2.5.1.1 and the review reply links look great. However, if my reply is to a diff comment, the content in the diff_comments section of the payload also looks quite a bit different from what is returned by the API. I didn't test, but this might also be the case with replies to screenshot and file-attachment comments.

david
#5 david

OK, that should be addressed in commit 8e9d4e6, which will ship in 2.5.2