3909: Change Description diff highlighting for changed part of line is incorrect

smacleod
chipx86
chipx86
What version are you running?
2.0.17

What's the URL of the page containing the problem?
/r/<rr-id>/

It appears the highlighting for which part of a line changed in change description diffs can be incorrect. A screenshot of the issue can be found at
https://bug1179930.bugzilla.mozilla.org/attachment.cgi?id=8629020

This was filed against MozReview as https://bugzilla.mozilla.org/show_bug.cgi?id=1179930 with the relavant review request being https://reviewboard.mozilla.org/r/12289/


The problematic changedescription contains the following:

{u'diff': {u'added': [[u'Diff r2', u'/r/12289/diff/2/', 25957]]}, u'description': {u'new': [u'Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange'], u'old': [u'Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r?mstange']}, u'summary': {u'new': [u'Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r=mstange'], u'old': [u'Bug 1178892 - Split the profiler into Core & Gecko files and break apart monolithic headers. r?mstange']}}
chipx86
#1 chipx86

Fix up at https://reviews.reviewboard.org/r/8525/

  • -Accepted
    +PendingReview
  • +chipx86
chipx86
#2 chipx86

Fixed on release-2.5.x (618e3cf187fd283b99e04ace2b17942c2c241b25)

  • -PendingReview
    +Fixed