3908: rbt post --diff-filename is broken in RBTools 0.6.3 and 0.7.3

seide******@gmai***** (Google Code) (Is this you? Claim this profile.)
david
david
July 7, 2015
What version are you running?

RBTools 0.6.3, 0.7.3


What's the URL of the page containing the problem?

NA

What steps will reproduce the problem?
1.  Use 'rbt diff' > mydiff to create a proper diff file
2.  rbt post --diff-filename mydiff CL


What is the expected output? What do you see instead?

I expect a review with diff uploaded. Instead I get this:

Traceback (most recent call last):
  File "/home/sallan/envs/rbtools-0.7.3/bin/rbt", line 9, in <module>
    load_entry_point('RBTools==0.7.3', 'console_scripts', 'rbt')()
  File "/home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/main.py", line 133, in main
    command.run_from_argv([RB_MAIN, command_name] + args)
  File "/home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/__init__.py", line 612, in run_from_argv
    exit_code = self.main(*args) or 0
  File "/home/sallan/envs/rbtools-0.7.3/lib/python2.6/site-packages/RBTools-0.7.3-py2.6.egg/rbtools/commands/post.py", line 751, in main
    if repository_info.supports_changesets and 'changenum' in diff_info:
UnboundLocalError: local variable 'diff_info' referenced before assignment


Same problem with RBTools 0.6.3.
Works correctly in 0.5.2.

What operating system are you using? What browser?

Mac OS-X, CentOS 6.6
Python 2.6.6
RB 1.7.28
Firefox, Safari, Chrome

Please provide any additional information below.

RBTools 0.5.2  :  works
RBTools 0.6.3  :  error
RBTools 0.7.3  :  error
david
#1 david
  • +PendingReview
  • +david
david
#2 david
Fixed in release-0.6.x (8ec9937). This will ship in 0.6.4 (if we do one) and 0.7.5. Thanks!
  • -PendingReview
    +Fixed