3844: SVN Post : doesn't support commit log with special characters

dumon*****@gmai***** (Google Code) (Is this you? Claim this profile.)
April 18, 2015 
What version are you running?
RBTools 0.7.2

What's the URL of the page containing the problem?
svn.py

What steps will reproduce the problem?
1. Use SVN as repository
2. Commit a modification with 'accented' characters (like à é è, etc.)
3. Try to push a post commit review with rbt post 'revision_number'

What is the expected output? What do you see instead?
RBTool must manage to parse the log to find the revision, even the log comment contains accented characters.

What operating system are you using? What browser?
Win 7. Mozilla.

Please provide any additional information below.
I managed to correct this issue with a DRAFT modification on svn.py, in the function _convert_symbolic_revision :
line 183 : 
   root = ElementTree.fromstring(log)
modified to : 
   root = ElementTree.fromstring(log.encode('utf-8'))

I haven't put a patch on review as it's certainly not the best way to correct this problem, but it confirms that the problem comes from here.

Regards,

Jonathan
brennie
#1 brennie 
The fix for this has landed on the release-0.7.x branch as commit ec1a47d. It will be included the next RBTools minor release (RBTools 0.7.3) as well as all future releases.
  • +Fixed
brennie
#2 brennie 
The fix for this has landed on the release-0.7.x branch as commit ec1a47d. It will be included the next RBTools minor release (RBTools 0.7.3) as well as all future releases.