3774: Active Directory login fails if group contains non-ascii characters

Hanko.*******@gmai***** (Google Code) (Is this you? Claim this profile.)
david
david
Feb. 23, 2015
What version are you running?
2.0.12

What's the URL of the page containing the problem?
confidential, not relevant


What steps will reproduce the problem?
1. user is in an AD group that contains non-ascii characters (e.g. é)
2. try to log in using Active Directory user name and password

What is the expected output? What do you see instead?
Expected:
successful sign-in
Actual: 
-log-in issue with the usual error message on client side
-the following error is shown in log: 
ERROR -  - Active Directory error: failed gettinggroups for user 'tgemes': 'ascii' codec can't decode byte 0xc3 in position 15: ordinal not in range(128)
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.12-py2.7.egg/reviewboard/accounts/backends.py", line 685, in authenticate
    group_names = self.get_member_of(con, user_data)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.12-py2.7.egg/reviewboard/accounts/backends.py", line 571, in get_member_of
    new_groups = [x.split(',')[0].split('=')[1] for x in member_of]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 15: ordinal not in range(128)

What operating system are you using? What browser?

Server is running on 
Linux <confidential_hostname> 3.13.0-43-generic #72-Ubuntu SMP Mon Dec 8 19:35:06 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
Server version: Apache/2.4.7 (Ubuntu)
Server built:   Jul 22 2014 14:36:38

The issue is browser-independent.

Please provide any additional information below.
Tried to set LANG environment variable to en_US.UTF-8 in /etc/apache2/envvars but it didn't help.
When the exception is caught for the problematic group the log-in is successful, but if the required group contains non-ascii characters this solution is not enough.

Please check this.

Best regards,
Gergely
david
#1 david
  • +PendingReview
  • +Component-Accounts
  • +david
david
#2 david
Fixed in release-2.0.x (becc0fe). Thanks!
  • -PendingReview
    +Fixed