3678: Unable to add new files to review requests

quest*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 31, 2015
What version are you running?
2.0.8

What's the URL of the page containing the problem?
https://git.reviewboard.kde.org/

What steps will reproduce the problem?
1. Set locale to it_IT
2. Open any review request you submitted
3.

What is the expected output? What do you see instead?
I'm unable to add files to the request, clicking the items of the menu does nothing.

What operating system are you using? What browser?
Debian GNU/Linux, Firefox 33/Chromium 38

Please provide any additional information below.
The problem appears to be an apostrophe that needs to be escaped.
See 'help_text' here below:

fields: [ { name: 'path', label: '<label for="id_path">Diff:</label>', required: true, help_text: 'Il nuovo diff da caricare.', widget: '<input id="id_path" name="path" type="file" />' },{ name: 'parent_diff_path', label: '<label for="id_parent_diff_path">Diff genitore:</label>', help_text: 'Un diff facoltativo su cui è basato il diff principale. Esso è solitamente usato per sistemi di controllo della versione distribuiti (Git, Mercurial, ecc.).', widget: '<input id="id_parent_diff_path" name="parent_diff_path" type="file" />' },{ name: 'base_commit_id', label: '<label for="id_base_commit_id">ID commit base:</label>', help_text: 'L'ID/revisione su cui si basa questa modifica.', widget: '<input id="id_base_commit_id" name="base_commit_id" type="text" />' } ]
david
#1 david
  • +EasyFix
#2 Chester.********@gmai***** (Google Code) (Is this you? Claim this profile.)
Do you mean setting locale to Italiano - Italian on the first step?
#3 quest*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Yes, set up the browser so that pages are in Italian when possible.
#4 teres*****@gmai***** (Google Code) (Is this you? Claim this profile.)
I'll try this.
david
#5 david
Fixed in djblets release-0.8.x (a4d3728). Thanks!
  • +Fixed