3652: rbt patch throws "OSError: [Errno 2] No such file or directory" if EDITOR contains flags

tinystat********@gmai***** (Google Code) (Is this you? Claim this profile.)
March 20, 2015
What version are you running?
RBTools 0.6

What's the URL of the page containing the problem?
n/a

What steps will reproduce the problem?
Simplest
1. EDITOR="vim -X" python -c "from rbtools.utils.console import edit_text; edit_text('')"
Alternately, 
1. EDITOR="vim -X" ./rbt patch --debug -c <issue>

What is the expected output? What do you see instead?
Expected: open editor to edit commit and then write commit. 
Actual: OSError: [Errno 2] No such file or directory, throw by subprocess.call

What operating system are you using? What browser?
OSX, n/a

Please provide any additional information below.
pass shell=True to `call`.
chipx86
#1 chipx86
  • +Confirmed
  • +EasyFix
    +Project-RBTools
    +Milestone-RBTools-Release0.6.x
    +Component-RBTools
#2 theo.b******@gmai***** (Google Code) (Is this you? Claim this profile.)
Mine, I should be able to fix this.
brennie
#3 brennie
This was fixed and was release in RBTools 0.7.

It landed on master as a38ca9b51b2d8b6b28e8a0c85de0b8803eb6adb5.
  • -Confirmed
    +Fixed