3511: SVN logs in New Review Request is not showing commits for today
- Fixed
- Review Board
anuj****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
Aug. 10, 2014 |
What version are you running? ReviewBoard 2.0.5 RBTools 0.6.2 Djblets 0.8.8 What's the URL of the page containing the problem? /r/new/ What steps will reproduce the problem? 1. Click on New Review Request 2. Select SVN branch from the dropdown shown What is the expected output? What do you see instead? The SVN logs that are displayed does not show commits of current date. It has logs till 'yesterday'. What operating system are you using? What browser? Ubuntu 12.04 Chrome 36 on Windows Please provide any additional information below. SCMTool configured: reviewboard.scmtools.svn.SVNTool
Can you verify that your reviewboard server and whatever client you're looking at are checking exactly the same server? We just run 'svn log'
ReviewBoard and SVN server are on different boxes. SVN is running on a Windows Server box. If I run "svn log" from a Windows client, I do get the right logs. Is there some sort of caching done by RB?
Is there a way I can disable caching to see if that is the problem area?
I see the following two constants in the above mentioned file: BRANCHES_CACHE_PERIOD = 60 * 5 # 5 minutes COMMITS_CACHE_PERIOD = 60 * 60 * 24 # 1 day Doesn't this mean that commits are cached for 1 day?
It does, but the commits are cached using a key that contains the tip, so if the branch advances, it won't use the cached commits.
After changing COMMITS_CACHE_PERIOD to 1 minute, the logs seem to be coming correctly. I'll monitor for a few more days to be 100% sure.