3444: Autocomplete is too aggressive

jameslin
Dec. 2, 2014
What version are you running? 2.0.3 alpha 0 (dev)

What's the URL of the page containing the problem? http://demo.reviewboard.org/


What steps will reproduce the problem?
1. Create two users: "john" and "johndoe".
2. Create a review request.
3. In the People list, type "john" and wait a moment.  The autocomplete list appears with "john" as the first match.
5. Type "doe" and hit the comma key to start adding a second reviewer.


What is the expected output? What do you see instead?
I expect my input to be unmolested if it's already valid, but "johndoe" (a valid username) gets replaced with "john" (the first autocomplete match).  Valid input should never be autocorrected.

Note that this does not happen if hitting the Enter key instead of comma.


What operating system are you using? What browser?
Firefox 30.0 on Windows 7 x64 SP1


Please provide any additional information below.
chipx86
#1 chipx86
  • +Confirmed
  • +EasyFix
    +Component-WebUI
    +Project-ReviewBoard
#2 adrw*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Oops, forgot to mention. I have started looking into this bug!
david
#3 david
Fixed in release-2.0.x (00bc85d). Thanks!
  • -Confirmed
    +Fixed
david
#4 david
Reverting the change because it's causing other problems.
  • -Fixed
    +Confirmed
david
#5 david
Fixed (for serious this time) in release-2.0.x (12eafa0).
  • -Confirmed
    +Fixed