3435: Example crontab shows deprecated "index" rb-site command

peter.s*******@gmai***** (Google Code) (Is this you? Claim this profile.)
david
david
July 11, 2014
What's the URL of the page containing the problem?
http://www.reviewboard.org/docs/manual/2.0/admin/sites/search-indexing/

Describe the problem and any recommendations below.

After an upgrade from RB 1.7.11 to RB 2.0.2, the example crontab in conf/search-cron.conf contains:

# Incremental indices every 10 minutes
0,10,20,30,40,50 * * * * "/usr/bin/python" "/usr/local/bin/rb-site" manage "/var/www/site" index
# Do a full index once a week on Sunday at 2am
0 2 * * 0 "/usr/bin/python" "/usr/local/bin/rb-site" manage "/var/www/site" index -- --full

However the documentation mentions elsewhere that "index" is deprecated, and "rebuild-index" or "update-index" should be used instead. It looks like this file wasn't updated during the RB upgrade. The date stamp on that file suggests it was installed during the initial 1.7.11 installation.


Please provide any additional information below.
chipx86
#1 chipx86
I've confirmed that the newer crontabs have the correct contents.

We should consider just overwriting the generated crontab in conf/ on upgrade.
david
#2 david
  • +PendingReview
  • +Project-ReviewBoard
    +Component-RB-Site
  • +david
david
#3 david
Fixed in release-2.0.x (8c41e45). Thanks!
  • -PendingReview
    +Fixed