3384: Content-Disposition is "inline" instead of "attachment" in response to Download Diff

java*****@gmai***** (Google Code) (Is this you? Claim this profile.)
June 3, 2014 
What version are you running? 1.7.21


What's the URL of the page containing the problem? e.g. /r/12345/diff/raw/


What steps will reproduce the problem?
1. Use Chrome, click "Download Diff".
2. Note that the response headers contain: Content-Disposition: inline; filename=some.patch
3. Chrome displays the diff inline, as instructed.  The file should be downloaded instead.  I think Content-Disposition: attachment;filename=some.patch should achieve this.

What is the expected output? What do you see instead?

Patch contents are displayed in the browser window.  For Download Diff, it should ... download.

What operating system are you using? What browser?

Chrome.  Firefox is not affected.

Please provide any additional information below.

See also discussion at https://groups.google.com/forum/#!topic/reviewboard/yhW3ycXwqVA
#1 java*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Priority of this is low for now, as I found that for some reason, Chrome as of 35.0.1916.114 seems to ignore "Content-Disposition: attachment" anyway and still renders inline.  Looks like a Chrome bug.  If that bug were fixed, then this change would become useful.
#2 java*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Actually I've falsely accused Chrome there; something was being cached.  So this can be fixed.
david
#3 david 
Fixed in release-2.0.x (855d395). Thanks!
  • +Fixed