3336: RBTools - Perforce - post/diff fail when using path instead of changelist number

e.smol******@gmai***** (Google Code) (Is this you? Claim this profile.)
david
david
May 13, 2014
What version are you running?
RBTools 0.6

What's the URL of the page containing the problem?
n/a

What steps will reproduce the problem?
1. Perforce repository - rbt diff //depot/path/to/file/...@cn1,@cn2
2.
3.

What is the expected output? What do you see instead?
Expected that diffs are genearted using the perforce path to extract revisions. Instead, the following error is generated

Failed to execute command: ['p4', '-G', 'change', '-o', '//depot/path/to/file/...@cn1,@cn2']

What operating system are you using? What browser?
Solaris

Please provide any additional information below.
The problem is that perforce.py tries to first interpret the path as a changelist and get its information, but then dies inside run_p4 instead of raising a InvalidRevisionSpecError exception.
david
#1 david
  • +PendingReview
  • +Component-RBTools
  • +david
david
#2 david
Fixed in master (a2fef4f). Thanks!
  • -PendingReview
    +Fixed