3328: rbt -I allows two separate review requests have identical commit ID

tomi*****@gmai***** (Google Code) (Is this you? Claim this profile.)
May 23, 2014
What version are you running?
2.0 RC2 (dev) (http://reviews.reviewboard.org)

What's the URL of the page containing the problem?
http://reviews.reviewboard.org/r/<id>

What steps will reproduce the problem?
1. Commit a change to files file[1|2]
2. rbt post -I file1
3. rbt post -I file2
4. Publish first review request and attempt to publish the second one

What is the expected output? What do you see instead?
Second review request gets published. Review board returns HTTP error 500 to the ajax request.

What operating system are you using? What browser?


Please provide any additional information below.
The issue is that both review requests have identical commit ID. Maybe the commit ID should not be stored when "--include" is given.
#1 matthew********@gmai***** (Google Code) (Is this you? Claim this profile.)
I'll work on this.
david
#2 david
  • +PendingReview
david
#3 david
Fixed in release-0.6.x (a65ee8d). Thanks!
  • -PendingReview
    +Fixed