3184: rbt status fails with perforce repository

seide******@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Jan. 17, 2014
What version are you running?

RBTools 0.5.2 and 0.5.2.dev
ReviewBoard 1.7.14


What's the URL of the page containing the problem?

NA


What steps will reproduce the problem?

1.  Attempt to list pending reviews from a ReviewBoard server using perforce as the repository.

What is the expected output? What do you see instead?

% rbt status -d 
DEBUG:root:Checking for a Subversion repository...
DEBUG:root:Running: svn info --non-interactive
DEBUG:root:Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: E155007: '/Users/sallan/PycharmProjects/rb_reports' is not a working copy
---
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Running: hg showconfig
DEBUG:root:Running: hg root
DEBUG:root:Command exited with rc 255: ['hg', 'root']
abort: no repository found in '/Users/sallan/PycharmProjects/rb_reports' (.hg not found)!
---
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Running: p4 info
DEBUG:root:Running: diff --version
DEBUG:root:repository info: Path: ['redacted'], Base path: None, Supports changesets: True
Traceback (most recent call last):
  File "/Users/sallan/envs/rbtools-master-2.6/bin/rbt", line 8, in <module>
    load_entry_point('RBTools==0.5.2.dev', 'console_scripts', 'rbt')()
  File "/Users/sallan/PycharmProjects/rbtools/rbtools/commands/main.py", line 113, in main
    command.run_from_argv([RB_MAIN] + args)
  File "/Users/sallan/PycharmProjects/rbtools/rbtools/commands/__init__.py", line 157, in run_from_argv
    exit_code = self.main(*args) or 0
  File "/Users/sallan/PycharmProjects/rbtools/rbtools/commands/status.py", line 60, in main
    client_name=self.options.repository_type)
  File "/Users/sallan/PycharmProjects/rbtools/rbtools/commands/__init__.py", line 188, in initialize_scm_tool
    tool.check_options()
  File "/Users/sallan/PycharmProjects/rbtools/rbtools/clients/perforce.py", line 298, in check_options
    if self.options.revision_range:
AttributeError: Values instance has no attribute 'revision_range'



What operating system are you using? What browser?

Tested on MacOS X and CentOS6.


Please provide any additional information below.

If I create an emtpy git repository, it uses that instead of perforce and works as expected:

% git init
Initialized empty Git repository in /Users/sallan/PycharmProjects/rb_reports/.git/
(rbtools-master-2.6)[sallan@buffy]~/PycharmProjects/rb_reports% rbt status -d
DEBUG:root:Checking for a Subversion repository...
DEBUG:root:Running: svn info --non-interactive
DEBUG:root:Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: E155007: '/Users/sallan/PycharmProjects/rb_reports' is not a working copy
---
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Running: git config core.bare
DEBUG:root:Running: git rev-parse --show-toplevel
DEBUG:root:Running: git symbolic-ref -q HEAD
DEBUG:root:Running: git config --get git-p4.port
DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'git-p4.port']
---
DEBUG:root:Running: git config --get branch.master.merge
DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'branch.master.merge']
---
DEBUG:root:Running: git config --get branch.master.remote
DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'branch.master.remote']
---
DEBUG:root:Running: git config --get remote.origin.url
DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'remote.origin.url']
---
DEBUG:root:Running: git config --get remote.origin.url
DEBUG:root:Command exited with rc 1: ['git', 'config', '--get', 'remote.origin.url']
---
DEBUG:root:repository info: Path: /Users/sallan/PycharmProjects/rb_reports/.git, Base path: , Supports changesets: False
DEBUG:root:Making HTTP GET request to http://giles/api/
DEBUG:root:Making HTTP GET request to http://giles/api/info/
DEBUG:root:Making HTTP GET request to http://giles/api/session/
DEBUG:root:Making HTTP GET request to http://giles/api/users/sallan/
DEBUG:root:Making HTTP GET request to http://giles/api/repositories/
WARNING:root:The repository detected in the current directory was not found on
the Review Board server. Displaying review requests from all repositories.
DEBUG:root:Making HTTP GET request to http://giles/api/review-requests/?status=pending&from-user=sallan&expand=draft
   r/148 - Put this in a numbered CL, then try 'post edit' without first creating a review.
 * r/149 - Make post Python 2.5 compatible.
<snip>
chipx86
#1 chipx86
Does this still happen with 0.5.3?
  • +NeedInfo
#2 seide******@gmai***** (Google Code) (Is this you? Claim this profile.)
Yes, same error with 0.5.3.
david
#3 david
  • +EasyFix
#4 markd*****@gmai***** (Google Code) (Is this you? Claim this profile.)
I have the same issue, rbt 0.5.3 and reviewboard 1.7.20
david
#5 david
  • -NeedInfo
    +New
chipx86
#6 chipx86
This should be fixed now for the upcoming 0.5.6.
  • -New
    +Fixed
  • +Milestone-RBTools-Release0.5
  • +chipx86
#7 north******@gmai***** (Google Code) (Is this you? Claim this profile.)
Do you know when 0.5.6 will be released? I may be having a similar problem.