3167: LDAP Bind password should not be cleared the second time you save the settings

ceesja******@gmai***** (Google Code) (Is this you? Claim this profile.)
david
david
Jan. 29, 2014
What version are you running?

git checkout of ReviewBoard, RBTools from December 3rd, 87597f428b7aafe02cd171042291c59189146ad0


What's the URL of the page containing the problem?

/admin/settings/authentication/


What steps will reproduce the problem?
1. Configure LDAP with Anonymous User Mask and Anonymous User Password
2. Save settings
3. Try to login with an LDAP account; it works
4. Open the authentication settings page again
5. Change nothing, press "save"
6. Try to login with an LDAP account; it fails


What is the expected output? What do you see instead?

I expected Reviewboard not to forget the bind password. I saw that the value is purged from the database though:


After saving the first time:

mysql> SELECT settings FROM siteconfig_siteconfiguration\G
*************************** 1. row ***************************
settings: {[...], "auth_ldap_anon_bind_passwd": "HFXXXXXXXXXXXXXXXX", [...]


After saving the second time:

mysql> SELECT settings FROM siteconfig_siteconfiguration\G
*************************** 1. row ***************************
settings: {[...], "auth_ldap_anon_bind_passwd": "", [...]


What operating system are you using? What browser?

Linux, Firefox


Please provide any additional information below.

The people at our place that can access the ReviewBoard admin already know the bind password, so for us it's no problem if the password is pre-filled and shown whenever you open the settings page
david
#1 david
  • +Component-Admin
david
#2 david
  • +PendingReview
  • +david
david
#3 david
Fixed in release-1.7.x (a0eaf37). Thanks!
  • -PendingReview
    +Fixed