3026: line expansion on the diff viewer page is broken

tehr*****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Aug. 28, 2013
What version are you running?

1.7.9.  Also seen in 1.8 alpha 0.

What's the URL of the page containing the problem?

http://reviews.reviewboard.org/r/4257/diff/#index_header

What steps will reproduce the problem?
1. Go to http://reviews.reviewboard.org/r/4257/diff/#index_header (your public site)
2. Press "+171 lines" at the top of "diffviewer.less"
3. Nothing happens.
4. Note that pressing the "+20" on the LHS will correctly expand by 20 lines.

What is the expected output? What do you see instead?

I expect to see the entire preceding contents of the file in the diff viewer.  Instead, nothing happens.

What operating system are you using? What browser?

Safari/Mac/latest.

Please provide any additional information below.
#1 tehr*****@gmai***** (Google Code) (Is this you? Claim this profile.)
To be clear: I see this on our privately hosted 1.7.9 instance as well as your publicly hosted 1.8 alpha instance.  I simply provided the link to your site since it'd be easier to demonstrate and presumably for you to debug.

Thanks!
Dan
chipx86
#2 chipx86
Thanks Dan. I've seen this as well and, without looking into 1.7.x, thought it was just a bug in the new diff viewer rewrite I've been doing. I'll look into a fix for this for both the next 1.7.x and 1.8.
  • +Confirmed
  • +Milestone-Release1.7.x
    +Component-DiffViewer
  • +chipx86
chipx86
#3 chipx86
Pushed to release-1.7.x (dfd180c)
  • -Confirmed
    +Fixed