2935: Diff currently unavailable.

0003****@zte.c***** (Google Code) (Is this you? Claim this profile.)
david
david
Aug. 13, 2013
What version are you running?
1.7.6

What's the URL of the page containing the problem?
when I click "view diff",error is :
Diff currently unavailable.
Error: 'Popen' object has no attribute 'kill'
Details
Traceback (most recent call last):
  File "c:\python25\lib\site-packages\ReviewBoard-1.7.6-py2.5.egg\reviewboard\diffviewer\views.py", line 383, in view_diff_fragment
    file = get_requested_diff_file()
  File "c:\python25\lib\site-packages\ReviewBoard-1.7.6-py2.5.egg\reviewboard\diffviewer\views.py", line 309, in get_requested_diff_file
    populate_diff_chunks(files, highlighting)
  File "c:\python25\lib\site-packages\ReviewBoard-1.7.6-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 1197, in populate_diff_chunks
    large_data=True)
  File "c:\python25\lib\site-packages\Djblets-0.7.11-py2.5.egg\djblets\util\misc.py", line 156, in cache_memoize
    data = lookup_callable()
  File "c:\python25\lib\site-packages\ReviewBoard-1.7.6-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 1196, in <lambda>
    enable_syntax_highlighting)),
  File "c:\python25\lib\site-packages\ReviewBoard-1.7.6-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 599, in get_chunks
    new = get_patched_file(old, filediff)
  File "c:\python25\lib\site-packages\ReviewBoard-1.7.6-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 392, in get_patched_file
    return patch(diff, buffer, filediff.dest_file)
  File "c:\python25\lib\site-packages\ReviewBoard-1.7.6-py2.5.egg\reviewboard\diffviewer\diffutils.py", line 235, in patch
    failure = p.wait()
  File "C:\Python25\lib\contextlib.py", line 33, in __exit__
    self.gen.throw(type, value, traceback)
  File "c:\python25\lib\site-packages\Djblets-0.7.11-py2.5.egg\djblets\util\contextmanagers.py", line 66, in controlled_subprocess
    process.kill()
AttributeError: 'Popen' object has no attribute 'kill'

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.
david
#1 david
  • +PendingReview
  • +david
david
#2 david
Fixed in djblets master (7d45fb5). This will ship with the next djblets release.
  • -PendingReview
    +Fixed