2933: Trim blank lines from the end (and beginning?) of review comments

jameslin
Sept. 21, 2013 
What version are you running?
1.6.13, but I also checked against demo.reviewboard.org which is running 1.7.5.


What's the URL of the page this enhancement relates to, if any?
http://demo.reviewboard.org/r/3189/#comment_rc4823-8953


Describe the enhancement and the motivation for it.
Blank lines at the end (and beginning) of review comments are saved as part of the comment.  Someone commenting on a review request might not notice that they've accidentally included blank lines at the end of their comment, however, and the excess lines are ugly.


What operating system are you using? What browser?
Windows 7 x64, Firefox 19.0.2
david
#1 david
  • +Component-Reviews
    +EasyFix
#2 edwl*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I'll be looking into this.
david
#3 david 
Edward, I think we have a pending change up that already fixes this: https://reviews.reviewboard.org/r/4533/

Sorry about the miscommunication.
#4 edwl*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
No problem.
david
#5 david 
Ok, it sounds like Christian's change fixes rendering in on the page but doesn't strip extra whitespace from the text itself, which means that editing it again still has extra lines, and emails will have them. You're welcome to work on this if you want :)
chipx86
#6 chipx86 
Sorry for the confusion!
#7 edwl*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Okay I'll work on this!
david
#8 david 
Fixed in master (63327ca). Thanks!
  • +Fixed