2779: Autocomplete enter key is not works in reviewers selection.

icu***@gmai***** (Google Code) (Is this you? Claim this profile.)
david
 david
Jan. 21, 2014 
What version are you running?
1.6.13

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Input first character of reviewers
2. Select reviewer
3. Press ENTER KEY

What is the expected output? What do you see instead?
I was expected to autocomplete as selected reviewer.
However It was selected just input characters.

What operating system are you using? What browser?
MacOSX/Safari

Please provide any additional information below.
#1 icu***@gmai***** (Google Code) (Is this you? Claim this profile.) 
ui.autocomplete.js:127 does not work?

                // matches also semicolon
                case options.multiple && $.trim(options.multipleSeparator) == "," && KEY.COMMA:
                case KEY.TAB:
                case KEY.ENTER:
                    if( selectCurrent() ) {
                        // stop default to prevent a form submit, Opera needs special handling
                        event.preventDefault();
                        blockSubmit = true;
                        return false;
                    }
                    break;
#2 icu***@gmai***** (Google Code) (Is this you? Claim this profile.) 
It works well in Reviewboard 1.6.3 with Djblets 0.6.14.
However, in Djblets 0.6.23, the problem occurs.
david
#3 david
  • +Milestone-Release1.7
david
#4 david
  • +Component-Reviews
david
#5 david
  • +EasyFix
#6 migu*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Working on this.
david
#10 david
  • +PendingReview
  • -Milestone-Release1.7
    -EasyFix
  • +david
david
#11 david 
Fixed in master (1df6d1f). This will ship with 2.0.
  • -PendingReview
    +Fixed