2545: Review Board does not understand patches that span directories included via svn:externals

bil****@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 19, 2014
What version are you running?

1.6.4.1

What's the URL of the page containing the problem?

/reviewboard/r/new/

What steps will reproduce the problem?
1. Create a directory in subversion, /a/
2. Create a directory in subversion, /b/
3. In /a/, create a subversion property "^/b b", so that /b/ is included as /a/b/
4. Create and 'svn add' two files, /a/a.txt, /a/b/b.txt.
5. Create a patch from /a/, containint those two files.
6. Submit the patch using New Review Request

What is the expected output? What do you see instead?

The expected output is to create a review as if /a/b/ had been a normal directory.  Instead, an error message is displayed: "The file 'https://svnserver/svn/a/b/b.txt' (r12345) could not be found in the repository"

What operating system are you using? What browser?

n/a

Please provide any additional information below.

n/a
#1 bil****@gmai***** (Google Code) (Is this you? Claim this profile.)
Sorry, step 3 should read

3. In /a/, create a subversion "svn:externals" property "^/b b", so that /b/ is included as /a/b/
david
#2 david
  • +Component-DiffParser
david
#3 david
Added --ignore-externals to 'svn status' calls in rbtools in master (5533790). The basic svn diff tool and rbtools won't create patches that span externals, so it's some third-party tool (tortoise?) that's causing problems.
  • +Fixed