This is a feature request.
I would like to be able to attach a file (other than a screenshot) to a review request.
For example, today I wanted to attach a small C file that was the test case that I used to test my
change.
For me, an idela interface would be:
Click on "Attach file"
Popup with the file path field+browse button, as well as a (new) radio button group:
o Image
o Text
o Other
"Image" attachments would be shown inline, as you do right now with screenshots (and people
can comment on them by selecting rectangles).
"Text" attachements would be shown inline, very similar to the right side of a diff when you add a
new file as part of your change. People would then be able to comment on your attachment just
like they comment on the main change.
Finally, "Other" attachments would not be shown inline. But reviewers would have the ability to
download them.
To prevent out-of-storage denial-of-service, a max size either per file upload, or per user.
