2382: Cannot create new user when LDAP_FULL_NAME_ATTRIBUTE is empty

bra***@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 12, 2012
What version are you running?
1.6.1

What's the URL of the page containing the problem?
https://myserver.mydomain.com/reviews/account/login/

What steps will reproduce the problem?
1. Setup LDAP authentication, leaving "Full Name Attribute" blank
2. A user who has never logged into Review Board (but exists in LDAP) attempts to log in (types **correct** username/password)
3. User is told "Incorrect username or password" (even though it's right)

What is the expected output? What do you see instead?

Expecting that the user account is created by Review Board and the user is logged in and taken to his/her dashboard.

Instead, GUI shows "Incorrect username or password", and Apache logs show this error message:
WARNING:root:An error while LDAP-authenticating: AttributeError("'Settings' object has no attribute 'LDAP_FULL_NAME_ATTRIBUTE'",)

I can rule out an incorrect username/password combination because of the *OTHER* error messages that I've seen in the Apache logs, such as:
 * When user types wrong username, I see:
   WARNING:root:LDAP error: The specified object does not exist in the Directory: mail=baduser@mydomain.com
 * When user types right username but wrong password I see:
   WARNING:root:LDAP error: The specified object does not exist in the Directory or provided invalid credentials: mail=user@mydomain.com
 * When user types right username but leaves password blank, I see:
   WARNING:root:Empty password for: mail=user@mydomain.com
 * When an *existing* user gets everything right, I see no error message.

What operating system are you using? What browser?
Server: Ubuntu 10.10
Client: Windows 7 + Firefox 7 or so (I don't have exact version numbers right now, but can provide it later if needed)

Please provide any additional information below.
LDAP worked fine before upgrading to 1.6.1.  We used 1.5.5 previously.

Even after the upgrade, *existing* users can log in without trouble.

LDAP settings are:
 * LDAP Server: ldaps://ldap.mydomain.com
 * LDAP Base DN: ou=People,o=mydomain.com
 * Given Name Attribute: givenName
 * Surname Attribute: sn
 * Full Name Attribute: <blank>
 * E-Mail Domain: <blank>
 * E-Mail LDAP Attribute: mail
 * Use TLS for authentication: <unchecked>
 * User Mask: mail=%s@mydomain.com
 * Anonymous User Mask: <blank>
 * Anonymous User Password: <blank>
david
#1 david
Fixed in master (cc02dc7). Thanks!
  • +Fixed