2334: rbtools does not correctly escape colons in passwords

rob***@blenkin******** (Google Code) (Is this you? Claim this profile.)
Nov. 4, 2011
What version are you running?
RBTools 0.4

What's the URL of the page containing the problem?
N/A

What steps will reproduce the problem?
1. Set your password to one containing colons
2. Attempt to use post-review
3.

What is the expected output? What do you see instead?
Should upload the diff, Got API Error 103 (HTTP code 401): You are not logged in

What operating system are you using? What browser?
Ubuntu 11.04, Browser: N/A

Please provide any additional information below.

By wiresharking the HTTP Post request, in the case my username is "rob" and password "my:password", post review attempts to use HTTP basic authentication with the value:

"rob:my:password"

Which is erroneous and causes post-review to fail.
david
#1 david
Fixed in djblets master (fe6fe86). Thanks!
  • +Fixed