1948: Using update_changenum in version 1.5.*

birb****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Feb. 20, 2011
What version are you running?
1.5

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Install latest reviewboard server
2. Try to use the update_changenum API function, e.g. http://servername/api/json/reviewrequests/4242/update_changenum/63584
3.

What is the expected output? What do you see instead?
It should update the change number of the given review request based on the argument passed. ERROR: 500

What operating system are you using? What browser?
Any.

Please provide any additional information below.
Server sends the following email:


Traceback (most recent call last):

  File "/usr/lib/python2.4/site-packages/Django-1.1.1-py2.4.egg/django/core/handlers/base.py", line 92, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/usr/lib/python2.4/site-packages/Django-1.1.1-py2.4.egg/django/views/decorators/cache.py", line 44, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)

  File "/usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/reviewboard/webapi/decorators.py", line 57, in _view
    response = view_func(*args, **kwargs)

  File "/usr/lib/python2.4/site-packages/Djblets-0.6.7-py2.4.egg/djblets/webapi/decorators.py", line 88, in _checklogin
    return view_func(*args, **kwargs)

TypeError: review_request_update_changenum() got an unexpected keyword argument 'api_format'


<ModPythonRequest
path:/api/json/reviewrequests/4242/update_changenum/63584,
GET:<QueryDict: {}>,
POST:<QueryDict: {}>,
COOKIES:{'__utma': '101380626.1940891473.1267446485.1280150918.1280471532.9',
 '__utmz': '101380626.1280471532.9.6.utmccn=(organic)|utmcsr=google|utmctr=Hatim+A+Tyabji|utmcmd=organic',
 'rbsessionid': '4bc438dd4960db03b795901ec1bf9652'},
META:{'AUTH_TYPE': None,
 'CONTENT_LENGTH': 0,
 'CONTENT_TYPE': None,
 'GATEWAY_INTERFACE': 'CGI/1.1',
 'HTTP_ACCEPT': 'application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5',
 'HTTP_ACCEPT_CHARSET': 'ISO-8859-7,utf-8;q=0.7,*;q=0.3',
 'HTTP_ACCEPT_ENCODING': 'gzip,deflate,sdch',
 'HTTP_ACCEPT_LANGUAGE': 'el-GR,el;q=0.8,en;q=0.6,en-US;q=0.4',
 'HTTP_CONNECTION': 'keep-alive',
 'HTTP_COOKIE': '__utma=101380626.1940891473.1267446485.1280150918.1280471532.9; __utmz=101380626.1280471532.9.6.utmccn=(organic)|utmcsr=google|utmctr=Hatim+A+Tyabji|utmcmd=organic; rbsessionid=4bc438dd4960db03b795901ec1bf9652',
 'HTTP_HOST': 'servername',
 'HTTP_USER_AGENT': 'Mozilla/5.0 (X11; U; Linux x86_64; en-US) AppleWebKit/534.7 (KHTML, like Gecko) Chrome/7.0.517.44 Safari/534.7',
 'PATH_INFO': u'/api/json/reviewrequests/4242/update_changenum/63584',
 'PATH_TRANSLATED': None,
 'QUERY_STRING': None,
 'REMOTE_ADDR': '10.8.6.206',
 'REMOTE_HOST': None,
 'REMOTE_IDENT': None,
 'REMOTE_USER': None,
 'REQUEST_METHOD': 'GET',
 'SCRIPT_NAME': '',
 'SERVER_NAME': 'servername',
 'SERVER_PORT': 80,
 'SERVER_PROTOCOL': 'HTTP/1.1',
 'SERVER_SOFTWARE': 'mod_python'}>
#1 birb****@gmai***** (Google Code) (Is this you? Claim this profile.)
I've written a Perforce trigger script that uses this API call to update the change number in RB once a fix goes in Perforce. This used to work with versions 1.0.*
#2 birb****@gmai***** (Google Code) (Is this you? Claim this profile.)
Actual version of the RB server running is 1.5.2.
chipx86
#3 chipx86
  • +Confirmed
  • +Milestone-Release1.5.x
chipx86
#4 chipx86
Fixed on release-1.5.x (153b56a). This will be in 1.5.4.
  • -Confirmed
    +Fixed
  • -Priority-Medium
    +Priority-High
    +Component-API
  • +chipx86