1828: 500 Error trying to "review" an image-only review request

Karr*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Sept. 26, 2010
What version are you running?
ReviewBoard 1.5 RC2
Django 1.1.1

What's the URL of the page containing the problem?
https://fedorahosted.org/reviewboard/r/79/reviews/draft/inline-form/

What steps will reproduce the problem?
1. Create a new review request on the "None" repository
2. Publish the review (I did so without adding any files to review)
3. Click on "Review"


What is the expected output? What do you see instead?
A review text entry box should appear, along with a shipit checkbox.
Instead, "A server error occurred. Show Details Dismiss" is displayed.

With debugging turned on, the traceback below is provided.

What operating system are you using? What browser?
Fedora 13, Mozilla Firefox 3.6.10

Please provide any additional information below.

Environment:

Request Method: GET
Request URL: https://fedorahosted.org/reviewboard/r/79/reviews/draft/inline-form/
Django Version: 1.1.1
Python Version: 2.4.3
Installed Applications:
['django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.markup',
 'django.contrib.sites',
 'django.contrib.sessions',
 'djblets.datagrid',
 'djblets.feedview',
 'djblets.siteconfig',
 'djblets.util',
 'djblets.webapi',
 'reviewboard.accounts',
 'reviewboard.admin',
 'reviewboard.changedescs',
 'reviewboard.diffviewer',
 'reviewboard.iphone',
 'reviewboard.reports',
 'reviewboard.reviews',
 'reviewboard.scmtools',
 'reviewboard.webapi',
 'fedora.django.auth',
 'django_evolution']
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.doc.XViewMiddleware',
 'django.middleware.http.ConditionalGetMiddleware',
 'django.middleware.locale.LocaleMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'fedora.django.auth.middleware.FasMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'djblets.siteconfig.middleware.SettingsMiddleware',
 'reviewboard.admin.middleware.LoadSettingsMiddleware',
 'djblets.log.middleware.LoggingMiddleware',
 'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')


Traceback:
File "/usr/lib/python2.4/site-packages/django/core/handlers/base.py" in get_response
  92.                 response = callback(request, *callback_args, **callback_kwargs)
File "/usr/lib/python2.4/site-packages/djblets/auth/util.py" in _checklogin
  46.             return view_func(request, *args, **kwargs)
File "/usr/lib/python2.4/site-packages/django/views/decorators/cache.py" in _cache_controlled
  30.             response = viewfunc(request, *args, **kw)
File "/usr/lib/python2.4/site-packages/reviewboard/reviews/views.py" in review_draft_inline_form
  270.     return render_to_response(template_name, RequestContext(request, {

Exception Type: AttributeError at /reviewboard/r/79/reviews/draft/inline-form/
Exception Value: 'NoneType' object has no attribute 'get_scmtool'
david
#1 david
  • +Milestone-Release1.5
david
#2 david
Fixed in revision cb5aa7a. Thanks!
  • +Fixed