1586: linkify is not enabled for Description and Testing Done if you don't own the review request

lon***@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
June 2, 2010
What version are you running?
1.5 Beta1

What's the URL of the page containing the problem?
http://reviews.reviewboard.org/r/1467/

What steps will reproduce the problem?
1.The link in "Testing Done" or "Description" is not linkified if you're 
not the review owner (or have admin rights)


What is the expected output? What do you see instead?
The links, or bugs , should show a link.  The links only show if you're the 
review owner.

What operating system are you using? What browser?
Any (Firefox, Chrome on Windows)

Please provide any additional information below.

I believe there problem is in reviewboard/htdocs/media/rb/js/reviews.js

The fields are linkified only under "if (window["gEditable"]) {" condition.

I'll work on a fix, unless this is a known issue already.
chipx86
#1 chipx86
Should check to see if this is broken on 1.0.x too.
  • +Confirmed
  • +Milestone-Release1.5
    +Component-Reviews
chipx86
#2 chipx86
  • +EasyFix
chipx86
#3 chipx86
Up for review at http://reviews.reviewboard.org/r/1614/
  • -Confirmed
    +PendingReview
chipx86
#4 chipx86
Fixed on master (61c6c09)
  • -PendingReview
    +Fixed
  • +chipx86