1577: Comments that were entered in a section of code that is folded are not visible, even when expanding that section

lon***@gmai***** (Google Code) (Is this you? Claim this profile.)
April 11, 2010
What version are you running?
1.5 Beta1

What's the URL of the page containing the problem?
http://demo.reviewboard.org/r/50/diff/#index_header

What steps will reproduce the problem?
1. Have a diffset with at least 2 files
2. Expand a section in the first file
3. Add a comment on one of the previously added line, publish
4. Reload the page, the expanding section is now collapsed
5. Expand the section again.  The comment is not visible.

In the example, the diffs have 3 files, so I put a comment on line 10 of 
the second file.  The comment is visible only is you use the expand all 
button.

The issue is in diffviewer.js,  function addCommentFlags(table, lines)
	gHiddenComments = remaining;
addCommentFlags is called for each file, so gHiddenComments is overwritten 
by the last file.

I'm testing a fix.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.
#1 lon***@gmai***** (Google Code) (Is this you? Claim this profile.)
A typo on point #3 above.  Should read:
Add a comment on one of the previously hidden lines, publish

See also http://reviews.reviewboard.org/r/1492/
david
#2 david
Fixed in master as 417cede.
  • +Fixed