1180: cvs.exe is never found on windows and it raises ImportError at /r/1/

marc****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
July 18, 2009
What version are you running?
reviewboard v1.0

What's the URL of the page containing the problem?
http://any-reviewboard-server/r/new

What steps will reproduce the problem?
1. create a new review request with a cvs repository

What is the expected output? What do you see instead?
the expected page (at least one input box to give a file)

What operating system are you using? What browser?
any browser - any windows system

Please provide any additional information below.
could be easily fixed by replacing the code below:
http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/scmtoo
ls/cvs.py, line 138
replace os.environ.get('IFS', ':') by os.pathsep

explanation:
it's quite uncommon to have such variable set on windows (IFS), so instead 
of putting ':', you should put ';', but from my point of view, using the 
solution given above is much much better.

Thanks for this great release!

Best Regards,

Marc Bee
chipx86
#1 chipx86
We'll get this fixed for a point release.
  • -Priority-Medium
    +Priority-Critical
    +Milestone-Release1.0.1
  • +david
chipx86
#2 chipx86
  • -Milestone-Release1.0.1
    +Milestone-Release1.0.x
chipx86
#3 chipx86
  • -david
    +chipx86
chipx86
#4 chipx86
Fixed in r2042
  • +Fixed