1056: "Review" button shouldn't leave the diff view

jameslin
chipx86
chipx86
April 20, 2009
What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. View the diff to some review request.
2. Click the "Review" button (because as I'm reading the diff, I want to
make some general comment about, say, the design).
3. Click the "Save" button.


What is the expected output? What do you see instead?
Reviewboard leaves the diff view and throws me to the review request's main
page.  Consequently, I've now lost my place in the diff.  IMO, this should
happen only when clicking "Publish", not "Save".


What operating system are you using? What browser?
Firefox 3.0.8 on Windows XP x64 SP2.


Please provide any additional information below.
chipx86
#1 chipx86
  • +Confirmed
  • +Milestone-Release1.0
    +Usability
    +Component-Reviews
    +EasyFix
  • +chipx86
chipx86
#2 chipx86
Fixed in r1914.
  • -Confirmed
    +Fixed